sql: support extended protocol binary format for Geometry/Geography/Box2D types

[cockroach-teamcity]

This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry link: https://sentry.io/organizations/cockroach-labs/issues/3252603016/?referrer=webhooks_plugin

Panic message:

encoding.go:797: error in argument for ×: unsupported OID 90000 with format code FormatBinary
--
*errutil.leafError: unsupported OID 90000 with format code FormatBinary (1)
encoding.go:797: *withstack.withStack (top exception)
*assert.withAssertionFailure
*errutil.withPrefix: error in argument for × (2)
conn_executor_prepare.go:387: *withstack.withStack (3)
*pgerror.withCandidateCode: 08P01 (4)
(check the extra data payloads)

Stacktrace (expand for inline code snippets):

cockroach/pkg/sql/conn_executor_prepare.go

Lines 386 to 388 in 1fac61a

	if err != nil {
	return retErr(pgerror.Wrapf(err, pgcode.ProtocolViolation,
	"error in argument for %s", k))

in pkg/sql.(*connExecutor).execBind

cockroach/pkg/sql/conn_executor.go

Lines 1626 to 1628 in 1fac61a

	res = ex.clientComm.CreateBindResult(pos)
	ev, payload = ex.execBind(ctx, tcmd)
	case DeletePreparedStmt:

in pkg/sql.(*connExecutor).execCmd

cockroach/pkg/sql/conn_executor.go

Lines 1449 to 1451 in 1fac61a

	var err error
	if err = ex.execCmd(ex.Ctx()); err != nil {
	if errors.IsAny(err, io.EOF, errDrainingComplete) {

in pkg/sql.(*connExecutor).run

cockroach/pkg/sql/conn_executor.go

Lines 483 to 485 in 1fac61a

	}()
	return h.ex.run(ctx, s.pool, reserved, cancel)
	}

in pkg/sql.(*Server).ServeConn

cockroach/pkg/sql/pgwire/conn.go

Lines 627 to 629 in 1fac61a

	reservedOwned = false // We're about to pass ownership away.
	retErr = sqlServer.ServeConn(ctx, connHandler, reserved, cancelConn)
	}()

in pkg/sql/pgwire.(*conn).processCommandsAsync.func1
/usr/local/go/src/runtime/asm_amd64.s#L1373-L1375 in runtime.goexit

pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).execBind at line 387
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).execCmd at line 1627
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).run at line 1450
pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn at line 484
pkg/sql/pgwire/conn.go in pkg/sql/pgwire.(*conn).processCommandsAsync.func1 at line 628
/usr/local/go/src/runtime/asm_amd64.s in runtime.goexit at line 1374

Tag	Value
Cockroach Release	v21.1.7
Cockroach SHA:	1fac61a
Platform	linux amd64
Distribution	CCL
Environment	development
Command	start-single-node
Go Version	``
# of CPUs
# of Goroutines

Jira issue: CRDB-15368

Epic CRDB-17785

[otan]

We definitely don't implement the binary protocol for spatial.

We probably should. Looks like it's a sent/received using WKB/EWKB:

• https://github.com/postgis/postgis/blob/6188339d51b2fea912cc0972a28302c806e1c7f4/postgis/lwgeom_inout.c#L684-L695
• https://github.com/postgis/postgis/blob/6188339d51b2fea912cc0972a28302c806e1c7f4/postgis/lwgeom_inout.c#L723-L730

[yuzefovich]

In this comment @carstenpiepel said:

This error is returned when transmitting a PostGIS geometry using the binary format/protocol. It appears that github.com/cockroachdb/cockroach/pkg/sql/pgwire/pgwirebase.DecodeDatum is missing a case for oidext.T_geometry and FormatBinary.