Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: new index backfiller not subject to admission control #80464

Closed
erikgrinaker opened this issue Apr 25, 2022 · 4 comments
Closed

sql: new index backfiller not subject to admission control #80464

erikgrinaker opened this issue Apr 25, 2022 · 4 comments
Assignees
@stevendanna
Labels
A-disaster-recovery branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-performance Perf of queries or internals. Solution not expected to change functional behavior. deprecated-branch-release-22.1.0 GA-blocker T-disaster-recovery

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Apr 25, 2022 •
edited by cockroach-jira-scripts
Loading

The new index backfiller in #73878 uses bare transactions for writes. These are not subject to admission control, and can easily overload the storage engine. It should add admission control headers (via e.g. DB.TxnWithAdmissionControl) using priority BulkNormalPri.

Jira issue: CRDB-15954
@erikgrinaker erikgrinaker added C-performance Perf of queries or internals. Solution not expected to change functional behavior. A-disaster-recovery T-disaster-recovery labels Apr 25, 2022
@blathers-crl
Copy link

blathers-crl bot commented Apr 25, 2022

cc @cockroachdb/bulk-io

@blathers-crl
Copy link

blathers-crl bot commented Apr 25, 2022

Hi @erikgrinaker, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@erikgrinaker erikgrinaker added branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 deprecated-branch-release-22.1.0 labels Apr 25, 2022
@erikgrinaker
Copy link
Contributor Author

This was fixed in #79721, leaving this open for 22.1 backports in #80420 and #80463.

@erikgrinaker erikgrinaker mentioned this issue Apr 25, 2022
Merged
@dt
Copy link
Member

dt commented Apr 27, 2022

#80420 and #80463 merged

@dt dt closed this as completed Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevendanna stevendanna

Labels
A-disaster-recovery branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-performance Perf of queries or internals. Solution not expected to change functional behavior. deprecated-branch-release-22.1.0 GA-blocker T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dt @jlinder @erikgrinaker @stevendanna