Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: close Replica.mu.snapshotChan when replica is destroyed #7806

Closed
petermattis opened this issue Jul 13, 2016 · 2 comments
Closed

storage: close Replica.mu.snapshotChan when replica is destroyed #7806

petermattis opened this issue Jul 13, 2016 · 2 comments
Labels
S-1-stability Severe stability issues that can be fixed by upgrading, but usually don’t resolve by restarting
Milestone
Q3

Comments

@petermattis
Copy link
Collaborator

There appears to be no cleanup of Replica.mu.snapshotChan when a replica is destroyed. This can leave the snapshot goroutine started in Replica.Snapshot dangling for a minute (defaultAsyncSnapshotMaxAge) as nothing comes along to consume the snapshot. Alternately, perhaps snapshotChan should be buffered.
@tamird
Copy link
Contributor

tamird commented Jul 13, 2016

Also see #7307; that PR likely suffers from the same issue, but the details are slightly different.

@petermattis petermattis added this to the Q3 milestone Jul 15, 2016
@petermattis petermattis added the S-1-stability Severe stability issues that can be fixed by upgrading, but usually don’t resolve by restarting label Jul 21, 2016
@tamird
Copy link
Contributor

tamird commented Oct 4, 2016

Replica.mu.snapshotChan is no longer a thing.

@tamird tamird closed this as completed Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-1-stability Severe stability issues that can be fixed by upgrading, but usually don’t resolve by restarting
Projects
None yet
Milestone
Q3
Development

No branches or pull requests
2 participants
@tamird @petermattis