dev: generate go does not pull all generated files back into the repo

[ajwerner]

Describe the problem

I noticed this with a mockgen target, but it appears, IIUC, that we pull very few files back from the sandbox in dev generate go. It appears that we only pull files as described here:

cockroach/build/bazelutil/checked_in_genfiles.txt

Lines 6 to 8 in 522e15b

	//pkg/roachpb:gen-batch-generated|batch_generated-gen.go|batch_generated.go
	//pkg/sql/opt/optgen/lang:gen-expr|expr-gen.og.go|expr.og.go
	//pkg/sql/opt/optgen/lang:gen-operator|operator-gen.og.go|operator.og.go

This is far less than ideal. If we're to replace the makefile and go generate more broadly, we need to be able to reliably pull every generated artifact we rely on back into the repo.

Solution

Let's make targets like the protobuf targets to hoist all the generated code.

Epic CRDB-8036

[rickystewart]

Hmm, this was definitely working at some point but it may have regressed. We don't have any stuff in CI to make sure there are no regressions.

[rickystewart]

I ran dev build short --debug and indeed we are pulling out not just those few files but a ton of stuff including .pb.go, .eg.go, etc. files. Are you seeing different behavior on your end?

[ajwerner]

I ran dev generate go and didn't see them pulled. I'll try again in a bit.

[rickystewart]

Is this bug stale now?

[ajwerner]

Yes, I think this is stale.