Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batcheval: support MVCC range tombstones in AddSSTable #76234

Closed
erikgrinaker opened this issue Feb 8, 2022 · 1 comment · Fixed by #83404
Closed

batcheval: support MVCC range tombstones in AddSSTable #76234

erikgrinaker opened this issue Feb 8, 2022 · 1 comment · Fixed by #83404
Assignees
@erikgrinaker
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Feb 8, 2022 •
edited by exalate-issue-sync bot
Loading

Once MVCC range tombstones are implemented (#70412) and supported in Export (#71398) we'll need to allow ingesting these SSTables via AddSSTable. Pebble should handle this just fine, so it's just a matter of handling it in the surrounding code (e.g. validation, timestamp rewrites, IngestAsWrites path, etc).

Jira issue: CRDB-13040

Epic CRDB-2624
@erikgrinaker erikgrinaker added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-storage Relating to our storage engine (Pebble) on-disk storage. T-kv-replication labels Feb 8, 2022
@erikgrinaker erikgrinaker self-assigned this Feb 8, 2022
@erikgrinaker erikgrinaker mentioned this issue Feb 8, 2022
Closed
@erikgrinaker
Copy link
Contributor Author

Needs cockroachdb/pebble#1765.

@erikgrinaker erikgrinaker mentioned this issue Jun 27, 2022
Merged
@craig craig bot closed this as completed in d324df1 Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

batcheval: support MVCC range tombstones in AddSSTable erikgrinaker/cockroach
1 participant
@erikgrinaker