Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: block_writer performance degradation #7594

Closed
petermattis opened this issue Jul 1, 2016 · 1 comment
Closed

perf: block_writer performance degradation #7594

petermattis opened this issue Jul 1, 2016 · 1 comment
Assignees

Comments

@petermattis
Copy link
Collaborator

The recent RocksDB tunings (#7532 and #7562) along with the optimization to parallelize processing of Replica.handleRaftReady (#7531) have improved the state of performance, but degradation still occurs. The first graph shows performance prior to these changes for a 1 hour run of block_writer:

screen shot 2016-07-01 at 3 22 46 pm

After the changes we see:

screen shot 2016-07-01 at 4 21 27 pm

A definite improvement, yet there is a sustained performance dip at ~45 min. My initial suspicion was that we reached another level of sstables. At the end of this test we were at 5 levels of sstables. But we reached the 5th level 4min into the test. I've run this test a few times and the dip always occurs around the same time frame. A few minutes after that I see an increase in the compaction rate.

@petermattis petermattis self-assigned this Jul 1, 2016
@petermattis
Copy link
Collaborator Author

Somewhere along the way this was fixed.

screen shot 2016-10-15 at 1 15 23 pm

Note that the above graph was taken from a 1h block_writer run on my laptop while the original message was from block_writer running on a 32-core GCE machine (so don't compare the absolute numbers). Since originally filing this issue I have replicated the original problem on my laptop, so this isn't a laptop vs GCE difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant