Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colfetcher: incorrectly report bytes read as 0 #75128

Closed
yuzefovich opened this issue Jan 19, 2022 · 0 comments · Fixed by #75175
Closed

colfetcher: incorrectly report bytes read as 0 #75128

yuzefovich opened this issue Jan 19, 2022 · 0 comments · Fixed by #75175
Assignees
@yuzefovich
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Jan 19, 2022 •
edited
Loading

KV bytes read is incorrectly reported as 0:
Screen Shot 2022-01-18 at 10 08 22 PM

The problem is that we are eagerly closing the cFetcher which nils out row.KVFetcher, and the latter is responsible for reporting the number of bytes read. The bug is present on master and probably on 21.2.
@yuzefovich yuzefovich added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Jan 19, 2022
@yuzefovich yuzefovich self-assigned this Jan 19, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Jan 19, 2022
@yuzefovich yuzefovich mentioned this issue Jan 19, 2022
Merged
@craig craig bot closed this as completed in 488a06b Jan 21, 2022
@blathers-crl blathers-crl bot mentioned this issue Jan 21, 2022
Merged
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

colfetcher: fix the bytes read statistic collection yuzefovich/cockroach
1 participant
@yuzefovich