Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show backup should show the "locality" of the backup #74857

Closed
livlobo opened this issue Jan 14, 2022 · 2 comments
Closed

Show backup should show the "locality" of the backup #74857

livlobo opened this issue Jan 14, 2022 · 2 comments
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. E-starter Might be suitable for a starter project for new employees or team members. T-disaster-recovery

Comments

@livlobo
Copy link
Contributor

livlobo commented Jan 14, 2022

Is your feature request related to a problem? Please describe.
When a user tries to restore a backup, it will be helpful for them to know if that backup was a multi-region backup and what the locality of the backup is, so that they can configure the destination cluster, db, table with the right locality, if needed. This is also required for implementing a more intuitive flow for self-service restores in CockroachDB Cloud.

Describe the solution you'd like
Add a "locality type" column to the SHOW BACKUP output - that will indicate:
For clusters / DB backups

  • Single region
  • Multi-region

For table backups

  • Regional by row
  • Regional by table
  • Global

Add a 'supported regions' column to SHOW BACKUP output - that will indicate the list of supported regions for that object type.

Describe alternatives you've considered

  • Ask the user if they are trying to restore a MR DB/Table (not a great UX, prone to user error)
  • Try to restore anyway, and interpret the error output (e.g. restoring descriptor 99 is not supported in a non multi-region db, etc.). This is also error prone because the error messages can't always be relied on to interpret whether that backup has multi-region objects within it. Also, it quite cumbersome to try to parse and analyze these.

Jira issue: CRDB-12296

@livlobo livlobo added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-disaster-recovery T-disaster-recovery labels Jan 14, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jan 14, 2022

cc @cockroachdb/bulk-io

@livlobo livlobo added the E-starter Might be suitable for a starter project for new employees or team members. label Jan 18, 2022
@shermanCRL shermanCRL added the E-quick-win Likely to be a quick win for someone experienced. label Feb 3, 2022
@msbutler
Copy link
Collaborator

msbutler commented Aug 5, 2022

duplicate of #79681 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. E-starter Might be suitable for a starter project for new employees or team members. T-disaster-recovery
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants