Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: TestMemoryLimit failed #74788

Closed
cockroach-teamcity opened this issue Jan 13, 2022 · 0 comments · Fixed by #74807
Closed

sql: TestMemoryLimit failed #74788

cockroach-teamcity opened this issue Jan 13, 2022 · 0 comments · Fixed by #74807
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

sql.TestMemoryLimit failed with artifacts on master @ c3d71ac887844bef174abb6dab2a4e1ce9270ab7:

../kv/kvclient/kvstreamer/budget.go:90 kvstreamer.(*budget).consume { func (b *budget) consume(ctx context.Context, bytes int64, allowDebt bool) error { }
../kv/kvclient/kvstreamer/streamer.go:510 kvstreamer.(*Streamer).Enqueue { allowDebt := len(reqs) == 1 }
row/kv_batch_streamer.go:77 row.NewTxnKVStreamer { reqs := spansToRequests(spans, false /* reverse */, keyLocking) }
rowexec/joinreader.go:896 rowexec.(*joinReader).readInput { kvBatchFetcher, err = row.NewTxnKVStreamer(jr.Ctx, jr.streamerInfo.Streamer, spans, jr.keyLocking) }
rowexec/joinreader.go:697 rowexec.(*joinReader).Next { case jrReadingInput: }
rowexec/stats.go:67 rowexec.(*inputStatCollector).Next { row, meta := isc.RowSource.Next() }
rowexec/filterer.go:82 rowexec.(*filtererProcessor).Next {  }
execinfra/base.go:187 execinfra.Run { // Emit the row; stop if no more rows are needed. }
execinfra/processorsbase.go:733 execinfra.(*ProcessorBaseNoHelper).Run { Run(pb.Ctx, pb.self, pb.Output) }
flowinfra/flow.go:453 flowinfra.(*FlowBase).Run { headProc.Run(ctx) }
distsql_running.go:566 sql.(*DistSQLPlanner).Run { // PlanAndRun. We should refactor this and get rid off ignoreClose field. }
distsql_running.go:1400 sql.(*DistSQLPlanner).PlanAndRun { recv.expectedRowsRead = int64(physPlan.TotalEstimatedScannedRows) }
conn_executor_exec.go:1411 sql.(*connExecutor).execWithDistSQLEngine { // need to have access to the main query tree. }
conn_executor_exec.go:1109 sql.(*connExecutor).dispatchToExecutionEngine { // plan has not been closed earlier. }
conn_executor_exec.go:720 sql.(*connExecutor).execStmtInOpenState {  }
conn_executor_exec.go:134 sql.(*connExecutor).execStmt { } else { }
conn_executor.go:1751 sql.(*connExecutor).execCmd.func1 {  }
conn_executor.go:1761 sql.(*connExecutor).execCmd { ex.statsCollector.PhaseTimes().SetSessionPhaseTime(sessionphase.SessionQueryServiced, timeutil.Now()) }
conn_executor.go:1675 sql.(*connExecutor).run { var err error }
conn_executor.go:680 sql.(*Server).ServeConn { }() }
pgwire/conn.go:665 pgwire.(*conn).processCommandsAsync.func1 { reservedOwned = false // We're about to pass ownership away. }

in another goroutine: happened before
../kv/kvclient/kvstreamer/streamer.go:758 kvstreamer.(*workerCoordinator).issueRequestsForAsyncProcessing { w.s.budget.mu.Lock() } <<<<<
../kv/kvclient/kvstreamer/streamer.go:757 kvstreamer.(*workerCoordinator).issueRequestsForAsyncProcessing { }() }
../kv/kvclient/kvstreamer/streamer.go:713 kvstreamer.(*workerCoordinator).mainLoop { err := w.issueRequestsForAsyncProcessing(ctx, requestsToServe, avgResponseSize) }
../util/stop/stopper.go:488 stop.(*Stopper).RunAsyncTaskEx.func2 { f(ctx) }

happened after
../kv/kvclient/kvstreamer/streamer.go:602 kvstreamer.(*Streamer).getNumRequestsInFlight { s.mu.Lock() } <<<<<
../kv/kvclient/kvstreamer/streamer.go:601 kvstreamer.(*Streamer).getNumRequestsInFlight { func (s *Streamer) getNumRequestsInFlight() int { }
../kv/kvclient/kvstreamer/streamer.go:760 kvstreamer.(*workerCoordinator).issueRequestsForAsyncProcessing {  }
../kv/kvclient/kvstreamer/streamer.go:713 kvstreamer.(*workerCoordinator).mainLoop { err := w.issueRequestsForAsyncProcessing(ctx, requestsToServe, avgResponseSize) }
../util/stop/stopper.go:488 stop.(*Stopper).RunAsyncTaskEx.func2 { f(ctx) }

Other goroutines holding locks:
goroutine 4876751 lock 0xc01427dc80
../kv/kvclient/kvstreamer/streamer.go:758 kvstreamer.(*workerCoordinator).issueRequestsForAsyncProcessing { w.s.budget.mu.Lock() } <<<<<
../kv/kvclient/kvstreamer/streamer.go:757 kvstreamer.(*workerCoordinator).issueRequestsForAsyncProcessing { }() }
../kv/kvclient/kvstreamer/streamer.go:713 kvstreamer.(*workerCoordinator).mainLoop { err := w.issueRequestsForAsyncProcessing(ctx, requestsToServe, avgResponseSize) }
../util/stop/stopper.go:488 stop.(*Stopper).RunAsyncTaskEx.func2 { f(ctx) }





ERROR: exit status 2

1 runs completed, 1 failures, over 1m14s
context canceled
Help

See also: How To Investigate a Go Test Failure (internal)
Parameters in this failure:

  • TAGS=deadlock

  • GOFLAGS=-parallel=4

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jan 13, 2022
@yuzefovich yuzefovich self-assigned this Jan 13, 2022
@craig craig bot closed this as completed in #74807 Jan 13, 2022
@craig craig bot closed this as completed in ca44523 Jan 13, 2022
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants