Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: enhance the circuit breaker probe #74701

Closed
tbg opened this issue Jan 11, 2022 · 1 comment
Closed

kvserver: enhance the circuit breaker probe #74701

tbg opened this issue Jan 11, 2022 · 1 comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale

Comments

@tbg
Copy link
Member

tbg commented Jan 11, 2022

Is your feature request related to a problem? Please describe.
The probe introduced for #33007 in #71806 issues a ProbeRequest only. While
this provides good coverage of the replication layer, it may be missing other
forms of unavailability such as deadlocked evaluation of read-only commands.

Describe the solution you'd like
Enhance the probe. Once the ProbeRequest has cleared, send a range-spanning read (possibly not an actual read, but something that acquires all latches and requires the lease) and clear the probe only if this returns within a timeout with either success or a credible NotLeaseholderError.

Jira issue: CRDB-12218

@tbg tbg added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jan 11, 2022
@tbg tbg self-assigned this Jan 14, 2022
@tbg tbg removed their assignment May 31, 2022
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale
Projects
None yet
Development

No branches or pull requests

2 participants