Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: circuit-break replicas when liveness not reachable #74616

Closed
tbg opened this issue Jan 10, 2022 · 1 comment
Closed

kvserver: circuit-break replicas when liveness not reachable #74616

tbg opened this issue Jan 10, 2022 · 1 comment
Labels
A-kv Anything in KV that doesn't belong in a more specific category. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-kv KV Team X-stale

Comments

@tbg
Copy link
Member

tbg commented Jan 10, 2022 •
edited by cockroach-jira-scripts
Loading

Touches #33007.

As of #71806, replicas generally fail fast when they're unable to replicate commands in a timely manner. However, when the liveness range is unavailable (or not reachable from a replica), this property does not hold (as documented in a test case in TestReplicaCircuitBreakers referencing this issue). This is somewhat similar (though only in spirit) to #74503.

Jira issue: CRDB-12174
@tbg tbg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv Anything in KV that doesn't belong in a more specific category. labels Jan 10, 2022
@blathers-crl blathers-crl bot added the T-kv KV Team label Jan 10, 2022
@tbg tbg mentioned this issue Jan 11, 2022
Closed
@tbg tbg self-assigned this Jan 14, 2022
@tbg tbg mentioned this issue Jan 14, 2022
Closed
@tbg tbg removed their assignment May 31, 2022
@github-actions GitHub Actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-kv Anything in KV that doesn't belong in a more specific category. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-kv KV Team X-stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikgrinaker @tbg