Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Create Statement Diagnostics Modal to not use refs #74221

Closed
lindseyjin opened this issue Dec 22, 2021 · 1 comment
Closed

Refactor Create Statement Diagnostics Modal to not use refs #74221

lindseyjin opened this issue Dec 22, 2021 · 1 comment
Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale

Comments

@lindseyjin
Copy link
Contributor

lindseyjin commented Dec 22, 2021 •
edited by cockroach-jira-scripts
Loading

Is your feature request related to a problem? Please describe.
We currently use a ref in the ActivateStatementDiagnosticsModal component. However, refs are an anti-pattern in React, and should not be used.

Describe the solution you'd like
Refactor ActivateStatementDiagnosticsModal and its usages to use data and props instead of refs. This modal is currently being used on the Statements Table and the Statements Details Page Diagnostics View.

Additional context
Follow-up from discussion on #74112

Epic CRDB-6619

Jira issue: CRDB-11978
@lindseyjin lindseyjin added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console labels Dec 22, 2021
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lindseyjin