Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: maintain key-span GC thresholds #73826

Closed
ajwerner opened this issue Dec 14, 2021 · 1 comment
Closed

kvserver: maintain key-span GC thresholds #73826

ajwerner opened this issue Dec 14, 2021 · 1 comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-kv KV Team X-stale

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Dec 14, 2021

Is your feature request related to a problem? Please describe.

Today each range maintains a GC threshold which covers its entire key span. This can get awkward when we want to merge ranges away after removing tables or indexes which might have had a shorter GC TTL. Today, nothing prevents such merges and such merges can result in unexpected violations of observed TTL behavior. This is also the proximate cause of #31563 and makes #31504 not viable.

Describe the solution you'd like
With the advent of cockroachdb/pebble#1339, we could imagine maintaining multiple GC thresholds for various subspans of a range. Generally these thresholds would converge to a single one, but, upon merge, they wouldn't need to.

Additional context

If we were really crazy, we could eventually leverage this to maintain different GC TTLs for different spans within a range.

Jira issue: CRDB-11766

@ajwerner ajwerner added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Dec 14, 2021
@blathers-crl blathers-crl bot added the T-kv KV Team label Dec 14, 2021
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-kv KV Team X-stale
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant