Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: rename setting disable_plan_gists to plan_gists_enabled #73348

Closed
rytaft opened this issue Dec 1, 2021 · 4 comments
Closed

sql: rename setting disable_plan_gists to plan_gists_enabled #73348

rytaft opened this issue Dec 1, 2021 · 4 comments
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-queries SQL Queries Team

Comments

@rytaft
Copy link
Collaborator

rytaft commented Dec 1, 2021

This would be more consistent with all other setting names and avoid setting a bad precedent

Jira issue: CRDB-11552

@rytaft rytaft added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Dec 1, 2021
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Dec 1, 2021
@cucaroach
Copy link
Contributor

Yeah I went back and forth on this and went with the default where the Go default value (false) gave us the behavior we wanted because of #70888. I think I was following the precedent of "disable_partially_distributed_plans"

@rytaft
Copy link
Collaborator Author

rytaft commented Dec 6, 2021

Seems like that might have been a mistake too -- most other boolean settings end with _enabled, and I think that matches up with what was discussed here: https://github.com/cockroachdb/cockroach/blob/master/docs/RFCS/20170317_settings_table.md#naming-the-last-part

@mgartner mgartner moved this to Backlog (DO NOT ADD NEW ISSUES) in SQL Queries Jul 24, 2023
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@mgartner
Copy link
Collaborator

mgartner commented Feb 1, 2024

I think the ship has sailed on this one. Closing.

@mgartner mgartner closed this as completed Feb 1, 2024
@github-project-automation github-project-automation bot moved this from Backlog (DO NOT ADD NEW ISSUES) to Done in SQL Queries Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-queries SQL Queries Team
Projects
Archived in project
Development

No branches or pull requests

3 participants