Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: 22.1 release checklist #73254

Closed
9 tasks done
rytaft opened this issue Nov 29, 2021 · 2 comments
Closed
9 tasks done

opt: 22.1 release checklist #73254

rytaft opened this issue Nov 29, 2021 · 2 comments
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team

Comments

@rytaft
Copy link
Collaborator

rytaft commented Nov 29, 2021

This issue captures a series of tests and steps that we need to run when 22.1 is getting close to being finalized.

  • check bug fixes that may need backport
  • check and update private opt tests repository
  • check regressions in microbenchmarks
  • run all tests with TAGS=fast_int_set_small and TAGS=fast_int_set_large
  • check that any new session settings have a cluster setting for the default (or a good justification for why not)
  • consider adding session+cluster settings for all new features
  • check TODOs in opt code (especially those added since the last release): sql: confirm that there are no outstanding TODOs required for the 22.1 release #79137
  • clone an instance of this issue for the next release
  • check the SQL Queries high likelihood bucket for issues that we'd really like to get into the release

Jira issue: CRDB-11497

@rytaft rytaft added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team labels Nov 29, 2021
@mgartner mgartner self-assigned this Mar 29, 2022
@mgartner
Copy link
Collaborator

mgartner commented Apr 7, 2022

SQL Queries session settings that were added without cluster default settings include:

  • disable_plan_gists
  • index_recommendations_enabled
  • null_ordered_last
  • cost_scans_with_default_col_size
  • default_transaction_quality_of_service
  • opt_split_scan_limit

@mgartner
Copy link
Collaborator

mgartner commented Apr 7, 2022

As of 22.1, users can set default session settings for all roles (or a particular role) with ALTER ROLE .... For example: ALTER ROLE ALL SET index_recommendations_enabled = false. So cluster settings aren't necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team
Projects
Archived in project
Development

No branches or pull requests

3 participants