Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanconfigjob: exempt requests to checkpoint from billing #72440

Closed
ajwerner opened this issue Nov 4, 2021 · 1 comment
Closed

spanconfigjob: exempt requests to checkpoint from billing #72440

ajwerner opened this issue Nov 4, 2021 · 1 comment
Labels
A-multitenancy Related to multi-tenancy A-zone-configs C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Nov 4, 2021

Is your feature request related to a problem? Please describe.

With the background job for spanconfig reconciliation, we peridically get updates from the rangefeed for checkpoints and we write them to the job progress. That's bad because the user will see their usage go up and up even when they are not doing anything.

Describe the solution you'd like
We should exempt the checkpointing. We also should probably rate-limit the checkpointing.

Additional context
This relates to #70538. We need to make sure also that the span config reconciler does not keep the tenant pod from scaling down.

@ajwerner ajwerner added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-zone-configs A-multitenancy Related to multi-tenancy labels Nov 4, 2021
@irfansharif
Copy link
Contributor

This led some valuable discussion internally; instead of exempting them from billing/tenant cost control, we should perhaps track background RUs separately down in KV, and use that tracking to determine the rate of free RUs we disburse. But in the short term lets not do anything, certainly nothing for this specific job. Since it's work that's being done on behalf of a tenant (work that's costing us), there's no need to exempt it from billing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-multitenancy Related to multi-tenancy A-zone-configs C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

No branches or pull requests

2 participants