Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: hibernate failed #71561

Closed
cockroach-teamcity opened this issue Oct 14, 2021 · 13 comments
Closed

roachtest: hibernate failed #71561

cockroach-teamcity opened this issue Oct 14, 2021 · 13 comments
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

roachtest.hibernate failed with artifacts on master @ 24d632ccabb7d03b887d399e705f7e1b6b9f7435:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/hibernate/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,hibernate.go:230,hibernate.go:242,test_runner.go:777: 
		Tests run on Cockroach v21.2.0-alpha.00000000-4994-g24d632ccab
		Tests run against hibernate 5.4.30
		8106 Total Tests Run
		8090 tests passed
		16 tests failed
		1901 tests skipped
		0 tests ignored
		2 tests passed unexpectedly
		0 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: org.hibernate.test.annotations.onetomany.OrderByTest.testOrderByOneToManyWithJoinTable -  (unexpected)
		--- PASS: org.hibernate.test.annotations.onetomany.OrderByTest.testOrderByNoElement -  (unexpected)
		For a full summary look at the hibernate artifacts 
		
		An updated blocklist (hibernateBlockList21_2) is available in the artifacts' hibernate log
Reproduce

See: roachtest README

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Oct 14, 2021
@rafiss rafiss removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Oct 14, 2021
@rafiss
Copy link
Collaborator

rafiss commented Oct 14, 2021

hm that's sketchy. this is on master but the test logs say it's using hibernateBlockList21_2.

cc @otan since you'd just updated the blocklist. (not that you caused the problem, but could you look since you were in the area?)

@otan
Copy link
Contributor

otan commented Oct 14, 2021

guessing it's because

[email protected]:5436/defaultdb> SELECT value FROM crdb_internal.node_build_info where field = 'Version';
                   value
-------------------------------------------
  v21.2.0-alpha.00000000-4995-g609830766d
(1 row)

when building on master. gotta wait for a new minted version.

@otan otan removed their assignment Oct 14, 2021
@rafiss
Copy link
Collaborator

rafiss commented Oct 15, 2021

Ah I believe that happened already. So then it should be a matter of applying the git tag of v22.1.0-alpha.00000000.


cc @celiala (not urgent) -- I see that for a0c04c6 (mint 21.1 cluster version) we applied a tag of v21.2.0-alpha.00000000.

Is it therefore correct that we should apply a tag of v22.1.0-alpha.00000000 to ea24703 (mint 21.2 cluster version)?

Asking because these ORM tests infer the version number from SELECT value FROM crdb_internal.node_build_info where field = 'Version'.

@cockroach-teamcity
Copy link
Member Author

roachtest.hibernate failed with artifacts on master @ 0984f873c6170ab34afe6fee4661fc5f76ac0dee:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/hibernate/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,hibernate.go:230,hibernate.go:242,test_runner.go:777: 
		Tests run on Cockroach v21.2.0-alpha.00000000-5058-g0984f873c6-dirty
		Tests run against hibernate 5.4.30
		8106 Total Tests Run
		8090 tests passed
		16 tests failed
		1901 tests skipped
		0 tests ignored
		2 tests passed unexpectedly
		0 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: org.hibernate.test.annotations.onetomany.OrderByTest.testOrderByOneToManyWithJoinTable -  (unexpected)
		--- PASS: org.hibernate.test.annotations.onetomany.OrderByTest.testOrderByNoElement -  (unexpected)
		For a full summary look at the hibernate artifacts 
		
		An updated blocklist (hibernateBlockList21_2) is available in the artifacts' hibernate log
Reproduce

See: roachtest README

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

@celiala
Copy link
Collaborator

celiala commented Oct 15, 2021

we should apply a tag of v22.1.0-alpha.00000000 to ea24703 (mint 21.2 cluster version)?

Done: v22.1.0-alpha.00000000

(This step was noted in the "New Major Version Checklist" but it wasn't clear when exactly to do this).

Hopefully that fixes the tests :)

@cockroach-teamcity
Copy link
Member Author

roachtest.hibernate failed with artifacts on master @ b3af96b0686773c78325d2b8b0623a8fcd3e9bf2:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/hibernate/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,hibernate.go:230,hibernate.go:242,test_runner.go:777: 
		Tests run on Cockroach v21.2.0-alpha.00000000-5076-gb3af96b068
		Tests run against hibernate 5.4.30
		8106 Total Tests Run
		8090 tests passed
		16 tests failed
		1901 tests skipped
		0 tests ignored
		2 tests passed unexpectedly
		0 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: org.hibernate.test.annotations.onetomany.OrderByTest.testOrderByNoElement -  (unexpected)
		--- PASS: org.hibernate.test.annotations.onetomany.OrderByTest.testOrderByOneToManyWithJoinTable -  (unexpected)
		For a full summary look at the hibernate artifacts 
		
		An updated blocklist (hibernateBlockList21_2) is available in the artifacts' hibernate log
Reproduce

See: roachtest README

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.hibernate failed with artifacts on master @ 5d972a683c531326bc0af403c6d3373d3f4b2267:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/hibernate/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,hibernate.go:230,hibernate.go:242,test_runner.go:777: 
		Tests run on Cockroach v21.2.0-alpha.00000000-5078-g5d972a683c
		Tests run against hibernate 5.4.30
		8106 Total Tests Run
		8090 tests passed
		16 tests failed
		1901 tests skipped
		0 tests ignored
		2 tests passed unexpectedly
		0 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: org.hibernate.test.annotations.onetomany.OrderByTest.testOrderByOneToManyWithJoinTable -  (unexpected)
		--- PASS: org.hibernate.test.annotations.onetomany.OrderByTest.testOrderByNoElement -  (unexpected)
		For a full summary look at the hibernate artifacts 
		
		An updated blocklist (hibernateBlockList21_2) is available in the artifacts' hibernate log
Reproduce

See: roachtest README

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

@celiala
Copy link
Collaborator

celiala commented Oct 18, 2021

Tests run on Cockroach v21.2.0-alpha.00000000-5078-g5d972a683c

Hmm, the tag is there (v22.1.0-alpha.00000000), but for some reason it's not getting detected 🤔

@rafiss
Copy link
Collaborator

rafiss commented Oct 18, 2021

I wonder if it the test runner node is not fetching the latest tags (similar to my question in https://cockroachlabs.slack.com/archives/CJ0H8Q97C/p1634334070424200)

@rafiss
Copy link
Collaborator

rafiss commented Oct 18, 2021

It looks like the issue is that the commit that was tagged does not actually belong to the master branch. There's a warning about it: 3f1f75d

@rafiss
Copy link
Collaborator

rafiss commented Oct 18, 2021

Probably either f8cfdae or ea24703 needs to be tagged instead

@celiala
Copy link
Collaborator

celiala commented Oct 18, 2021

Ah, thank you!

okay, I tagged f8cfdae as v22.1.0-alpha.00000000

@rafiss
Copy link
Collaborator

rafiss commented Oct 19, 2021

Tests are good now! Thanks @celiala !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Projects
None yet
Development

No branches or pull requests

4 participants