-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: internal error: expected *DJSON, found tree.dNull #70663
Comments
Full trace
I think we want to disallow casting between different arrays of tuples. We already disallow casting between tuples. |
Hm, actually I think we already disallow that cast. But the optimizer seems to be adding that cast anyway in cockroach/pkg/sql/opt/optbuilder/union.go Lines 200 to 202 in ad275ab
But perhaps that's only because some other type-checking logic somewhere is incorrect. @rytaft would you be able to comment on whether this would be more of an optimizer fix or a type-checking fix? |
I don't really know how this works, so I'll defer to @RaduBerinde and @rytaft. An example repro is
For reference, here is Postgres:
|
Maybe @mgartner knows something too since he's be looking into the assignment casts recently. |
The
However, the query works correctly in v20.2.5. I ran a git bisect, and the first bad commit on the v20.2 branch is #61086. That is a backport of 4037bd8 which made it into v21.1.0. This commit deals with the |
This comment has been minimized.
This comment has been minimized.
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 37d9f72a28a8e009bc6ba3c4d3c5780af554b92d: Random syntax error:
Query:
Schema:
ReproduceTo reproduce, try: make stressrace TESTS=TestRandomSyntaxSQLSmith PKG=./pkg/sql/tests TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1 Same failure on other branches
Internal log
/cc @cockroachdb/sql-experience rafiss |
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 80844e44f4f9d0e565c6e810bd4c782be61899bf: Random syntax error:
Query:
Schema:
ReproduceTo reproduce, try: make stressrace TESTS=TestRandomSyntaxSQLSmith PKG=./pkg/sql/tests TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1 Same failure on other branches
Internal log
/cc @cockroachdb/sql-experience rafiss |
Filed #70831 to track the bug separately from this test. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 1fc4fc1493eb4bb521b2ffb6f7904891395f4b47: Random syntax error:
Query:
Schema:
ReproduceTo reproduce, try: make stressrace TESTS=TestRandomSyntaxSQLSmith PKG=./pkg/sql/tests TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1 Same failure on other branches
Internal log
/cc @cockroachdb/sql-experience rafiss |
This comment has been minimized.
This comment has been minimized.
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 9013165fa81c4cddbe38b73c8b429faa3de226e3: Random syntax error:
Query:
Schema:
ReproduceTo reproduce, try: make stressrace TESTS=TestRandomSyntaxSQLSmith PKG=./pkg/sql/tests TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1 Same failure on other branches
Internal log
/cc @cockroachdb/sql-experience rafiss |
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 5ac733bb4927020bc1c52da24b2591742fde8e1f: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ fdd672fed84323279f7070127f36cdbdc5c26b03: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ c3d71ac887844bef174abb6dab2a4e1ce9270ab7: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ d6b99e92bf55b6f4a0d79800d67924e04d0b2a6d: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 78419450178335b31f542bd1b14fefdf4ecee0e8: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 5ad21e3896ee809e9c3ebc28bb22166f1275acca: Random syntax error:
Query:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 4b41789120e019ab015e6dbb924df763897ebadb: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 365b4da8bd02c06ee59d2130a56dec74ffc9ce21: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 912964e02ddd951c77d4f71981ae18b3894e9084: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ da01e4c0545f191a0573e1d097ff0366769e0d6b: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 58ceac139a7e83052171121b28026a7366f16f7e: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ dc07599dc9db1acd5afa3a6537297815f25c1fca: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ e1068d77afbd39b162978281c9da7cbea49c1c3a: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 83e2df701688745fe7e7d8a0d0e5e7a4ba8633c8: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 71becf337d9d2731298dc092f3ce9cf0f0eedb2c: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ bb85ddc4fc0ad8761d7aba61315da22b433022e3: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ a5158c4c93e9dca858b38ef7e94321f0a0a2b5c5: Random syntax error:
Query:
Schema:
Same failure on other branches
|
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 95c82a7dbc6d6fecb63edbd666c9986d1ad3885b: Random syntax error:
Query:
Schema:
Same failure on other branches
|
All the latest |
sql/tests.TestRandomSyntaxSQLSmith failed with artifacts on master @ 85b1e92455eb2795043d71e5766b1b56dab308f2:
Random syntax error:
Query:
Schema:
Reproduce
To reproduce, try:
Same failure on other branches
Internal log
/cc @cockroachdb/sql-experience rafiss
This test on roachdash | Improve this report!
Jira issue: CRDB-10164
The text was updated successfully, but these errors were encountered: