Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: rangefeed handling of AddSSTable #70434

Closed
erikgrinaker opened this issue Sep 20, 2021 · 0 comments · Fixed by #73487
Closed

kvserver: rangefeed handling of AddSSTable #70434

erikgrinaker opened this issue Sep 20, 2021 · 0 comments · Fixed by #73487
Assignees
@erikgrinaker
Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Sep 20, 2021 •
edited
Loading

Once AddSSTable writes entries at the current timestamp in #70422, we need to expose these via the rangefeed. A few options:

  • Emit Put events for each value in the SST.
  • Emit the binary SST, and let subscribers deal with iteration and other processing.
  • Restart the rangefeed at a suitable timestamp and rely on a catchup scan.
@erikgrinaker erikgrinaker added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-replication Relating to Raft, consensus, and coordination. T-kv KV Team labels Sep 20, 2021
@erikgrinaker erikgrinaker mentioned this issue Sep 20, 2021
Closed
@erikgrinaker erikgrinaker mentioned this issue Oct 28, 2021
Closed
@erikgrinaker erikgrinaker self-assigned this Oct 28, 2021
@erikgrinaker erikgrinaker mentioned this issue Nov 13, 2021
Closed
This was referenced Dec 5, 2021
Merged
Closed
@craig craig bot closed this as completed in 11da0cf Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
None yet
Milestone
No milestone
1 participant
@erikgrinaker