Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: RPC to lock a key span for exclusive access #70431

Closed
erikgrinaker opened this issue Sep 20, 2021 · 1 comment
Closed

kvserver: RPC to lock a key span for exclusive access #70431

erikgrinaker opened this issue Sep 20, 2021 · 1 comment
Labels
A-kv-server Relating to the KV-level RPC server C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-kv KV Team X-stale

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Sep 20, 2021

As described in #69380, even though we want to move to MVCC-compliant operations (#70429), we will still have some use for non-MVCC operations such as RevertRange, e.g. during streaming replication cutover. However, we should formalize the use of these operations by requiring the key span to be globally locked for access, to ensure that no other components are interacting with the span during this time. This would likely involve some sort of LockSpan RPC used to acquire and release global locks for a key span, with a lock token that must be used by when sending non-MVCC RPC commands like RevertRange, ClearRange, and AddSSTable with historical timestamps.

Jira issue: CRDB-10073

@erikgrinaker erikgrinaker added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-server Relating to the KV-level RPC server T-kv KV Team labels Sep 20, 2021
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-server Relating to the KV-level RPC server C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-kv KV Team X-stale
Projects
None yet
Development

No branches or pull requests

1 participant