Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/sem/builtins: gateway_region should not be marked as VolatilityStable #69598

Closed
ajwerner opened this issue Aug 30, 2021 · 0 comments · Fixed by #69624
Closed

sql/sem/builtins: gateway_region should not be marked as VolatilityStable #69598

ajwerner opened this issue Aug 30, 2021 · 0 comments · Fixed by #69624
Labels
A-multiregion Related to multi-region C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@ajwerner
Copy link
Contributor

Describe the problem

It is currently marked as VolatilityStable. However, during the execution of a single statement, it can return different values when run on different nodes in DistSQL. Either we need to:

  1. Disallow the function with distsql (set DistsqlBlocklist).
  2. Mark it as VolatilityVolatile.
  3. Propagate the locality information of the gateway to distsql flows and use it.
@ajwerner ajwerner added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-multiregion Related to multi-region labels Aug 30, 2021
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Aug 30, 2021
@otan otan mentioned this issue Aug 31, 2021
Merged
@craig craig bot closed this as completed in b0379ad Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-multiregion Related to multi-region C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

builtins: block gateway_region from DistSQL otan-cockroach/cockroach
1 participant
@ajwerner