Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify icon components in cluster-ui #68501

Closed
matthewtodd opened this issue Aug 5, 2021 · 1 comment
Closed

Unify icon components in cluster-ui #68501

matthewtodd opened this issue Aug 5, 2021 · 1 comment
Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@matthewtodd
Copy link
Contributor

Right now, there are 2 or 3 different ways of doing it.

Let's move to a single Icon component that loads SVGs from external files -- the external files are nice because they let us use standard tools to look at them, rather than reading a wall of XML embedded in a React Component.
@matthewtodd matthewtodd added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console labels Aug 5, 2021
@matthewtodd matthewtodd changed the title Unify icon components in cluster-ui. Unify icon components in cluster-ui Aug 5, 2021
@matthewtodd
Copy link
Contributor Author

Closing as irrelevant; I rolled back the new Icon component because its use of data-uri images prevent sizing and coloring the svgs with css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthewtodd