Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose number of keys mvcc_incremental_iterator skips over for better resource accounting #68234

Closed
aliher1911 opened this issue Jul 29, 2021 · 0 comments · Fixed by #68467
Closed

Expose number of keys mvcc_incremental_iterator skips over for better resource accounting #68234

aliher1911 opened this issue Jul 29, 2021 · 0 comments · Fixed by #68467
Assignees
@aliher1911
Labels
A-kv Anything in KV that doesn't belong in a more specific category. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@aliher1911
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When backup runs an export request it could iterate over large amount of non matching keys which could cause cpu starvation for higher priority requests. This is limited to certain extent by reducing size of single request, but if number of matching keys is low it doesn't allow efficiently throttling backups.

Describe the solution you'd like
Provide limits for processed keys during iteration regardless of the fact that they match export criteria or not.

Additional context
Part of #66486
@aliher1911 aliher1911 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv Anything in KV that doesn't belong in a more specific category. T-kv KV Team labels Jul 29, 2021
@aliher1911 aliher1911 self-assigned this Jul 29, 2021
@aliher1911 aliher1911 mentioned this issue Aug 5, 2021
Merged
@craig craig bot closed this as completed in cf4fe62 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aliher1911 aliher1911

Labels
A-kv Anything in KV that doesn't belong in a more specific category. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

storage: add limits to skipped data iteration aliher1911/cockroach
1 participant
@aliher1911