Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrations: use startup migration for tenants' system.zones #67681

Closed
irfansharif opened this issue Jul 15, 2021 · 2 comments
Closed

migrations: use startup migration for tenants' system.zones #67681

irfansharif opened this issue Jul 15, 2021 · 2 comments
Assignees
Labels
A-zone-configs C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@irfansharif
Copy link
Contributor

irfansharif commented Jul 15, 2021

Part of #66348. In #67323 we introduced per-tenant system.zones using tenant migrations for extant tenants, and bootstrap code for new tenants. Startup migrations (today called sqlmigrations) seem better suited for introducing new system tables + populating it with initial static values.

@blathers-crl
Copy link

blathers-crl bot commented Jul 15, 2021

Hi @irfansharif, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@irfansharif irfansharif added A-zone-configs C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Jul 15, 2021
@irfansharif
Copy link
Contributor Author

Not doing this, keeping it as a tenant migration + bootstrap. #69169.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-zone-configs C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

No branches or pull requests

2 participants