Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: add batch timeouts during intent GC #67296

Closed
erikgrinaker opened this issue Jul 7, 2021 · 0 comments · Fixed by #67990
Closed

kvserver: add batch timeouts during intent GC #67296

erikgrinaker opened this issue Jul 7, 2021 · 0 comments · Fixed by #67990
Assignees
Labels
A-kv Anything in KV that doesn't belong in a more specific category. C-performance Perf of queries or internals. Solution not expected to change functional behavior. T-kv KV Team

Comments

@erikgrinaker
Copy link
Contributor

In #65001 we increased the MVCC GC timeout to 10 minutes. However, the intent resolution done as part of this GC is dependant on other ranges, and if a single range is unavailable it will halt further intent resolution until the 10 minute timeout triggers, preventing progress on other intents.

Once #65847 lands, we should add per-batch intent resolution timeouts, to ensure we always make some progress even in the face of unavailable ranges.

@erikgrinaker erikgrinaker added C-performance Perf of queries or internals. Solution not expected to change functional behavior. A-kv Anything in KV that doesn't belong in a more specific category. T-kv KV Team labels Jul 7, 2021
@erikgrinaker erikgrinaker self-assigned this Jul 7, 2021
@craig craig bot closed this as completed in 3fd1428 Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv Anything in KV that doesn't belong in a more specific category. C-performance Perf of queries or internals. Solution not expected to change functional behavior. T-kv KV Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant