-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Smooth out issues with generated protobuffer definitions. #6616
Comments
I don't think it's necessary to enumerate the hacks. Looking ahead slightly, I have a branch in which I use It's also my understanding that typescript@next supports importing javascript without definition files, and also pulling type information from JsDoc comments. My current understanding of this is "tracked" upstream: microsoft/TypeScript#9317. The next step here is to experiment with typescript@next on that branch. |
Gotcha. I'll assign to you for now. |
Quick update on this: the code produced by https://github.com/google/protobuf/tree/master/js is not yet suitable for use directly with the typescript compiler (even
|
More update: filed microsoft/TypeScript#9509. |
In the next version of our admin UI, we are now generating proto-buffer definitions directly from .proto files. This is accomplished using a couple of open-source tools (proto2js, Proto2Typescript). Unfortunately, there are incompatibilities between the output of Proto2Typescript and the systemjs typescript plugin (plugin-typescript), and we have worked around some of these issues with "hacks".
We should figure out the best way to improve the protobuffer generation process so that these hacks are not necessary.
The text was updated successfully, but these errors were encountered: