Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: Add version number to base64 form of join tokens #64885

Closed
itsbilal opened this issue May 7, 2021 · 2 comments
Closed

security: Add version number to base64 form of join tokens #64885

itsbilal opened this issue May 7, 2021 · 2 comments
Labels
A-authentication Pertains to authn subsystems C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) good first issue

Comments

@itsbilal
Copy link
Contributor

itsbilal commented May 7, 2021

Join tokens are created by the create_join_token() SQL builtin and
returned as base64 encoded strings.

  • To account for any future
    modifications to the join token format, the marshalled form of it
    should have a version number in it at a fixed offset (ideally 0)
    in addition to all the existing fields. This will ease in any future
    updates to the join token format.
  • the base64 format can produce strings that start with a hyphen (-) and this confuses the command-line parser when pasted in argument position on the command line for cockroach connect join.

Stems from #60632.
Epic: CRDB-6663

@itsbilal itsbilal added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) good first issue labels May 7, 2021
@nikola-n6c
Copy link
Contributor

Hey, I’d like to work on this. It’d be my first contribution to the project. Ok if I poke around and try to get a draft implementation on my own? Anything I should keep in mind? Thanks

@itsbilal
Copy link
Contributor Author

Fixed in #65329 - thanks @nikola-n6c !

@knz knz added the A-authentication Pertains to authn subsystems label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-authentication Pertains to authn subsystems C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) good first issue
Projects
None yet
Development

No branches or pull requests

3 participants