Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: align flag names in the CLI with configuration vars inside the code #64269

Closed
otan opened this issue Apr 27, 2021 · 2 comments
Closed

cli: align flag names in the CLI with configuration vars inside the code #64269

otan opened this issue Apr 27, 2021 · 2 comments
Labels
A-cli-flags Pertains to CLI flag handling common to all CLI commands C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-server-and-security DB Server & Security X-stale

Comments

@otan
Copy link
Contributor

otan commented Apr 27, 2021 •
edited by cockroach-jira-scripts
Loading

Example: field is currently named SimulateLatency in the demoCtx, and --global as a flag.

It is worth renaming both of these to something that makes more sense, e.g. --simulate-geo-latency, --simulate-real-world-latencies, or something of the ilk, and renaming the flag and marking --global as deprecated.

Context available here

Jira issue: CRDB-6978
@otan otan added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cli-client CLI commands that pertain to using SQL features labels Apr 27, 2021
@otan otan mentioned this issue Apr 27, 2021
Merged
@knz
Copy link
Contributor

knz commented Apr 27, 2021

thank you

@knz knz changed the title cli: consider renaming cockroach demo --global cli: align flag names in the CLI with configuration vars inside the code Apr 27, 2021
@knz knz added A-cli-flags Pertains to CLI flag handling common to all CLI commands C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. and removed A-cli-client CLI commands that pertain to using SQL features labels Apr 27, 2021
@jlinder jlinder added the T-server-and-security DB Server & Security label Jun 16, 2021
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cli-flags Pertains to CLI flag handling common to all CLI commands C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-server-and-security DB Server & Security X-stale
Projects
No open projects
DB Server & Security
Status: Done 21.2
SQL CLI (demo + sql + workload + dump)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlinder @knz @otan