Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: crdb_internal.node_statement_statistics should contain statement id #64072

Closed
Azhng opened this issue Apr 22, 2021 · 0 comments · Fixed by #64076
Closed

sql: crdb_internal.node_statement_statistics should contain statement id #64072

Azhng opened this issue Apr 22, 2021 · 0 comments · Fixed by #64076
Assignees
@Azhng
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@Azhng
Copy link
Contributor

Azhng commented Apr 22, 2021

Currently, in crdb_internal.node_transaction_statistics view, we reference crdb_internal.node_statement_statistics view through statement_ids column. However, we do not include statement id as part of the the crdb_internal.node_statement_statistics view. This means that we cannot perform lookup on the statement view using the information from the transaction view.

cc: @kevin-v-ngo, @arulajmani
@Azhng Azhng added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Apr 22, 2021
@Azhng Azhng self-assigned this Apr 22, 2021
@Azhng Azhng mentioned this issue Apr 22, 2021
Merged
@craig craig bot closed this as completed in 9212a05 Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Azhng Azhng

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add statement_id to crdb_internal.node_statement_statistics Azhng/cockroach
1 participant
@Azhng