Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: Correctly account memory when flushing compressed files #63888

Closed
miretskiy opened this issue Apr 19, 2021 · 1 comment · Fixed by #63891
Closed

changefeedccl: Correctly account memory when flushing compressed files #63888

miretskiy opened this issue Apr 19, 2021 · 1 comment · Fixed by #63891
Assignees
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker

Comments

@miretskiy
Copy link
Contributor

Cloudstorage sinks incorrectly account for memory when flushing compressed
files to cloud storage.
When closing "codec" we may write additional bytes to memory buffer, and those bytes must be correctly accounted for.

@miretskiy miretskiy added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-cdc Change Data Capture labels Apr 19, 2021
@miretskiy miretskiy self-assigned this Apr 19, 2021
@blathers-crl
Copy link

blathers-crl bot commented Apr 19, 2021

Hi @miretskiy, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant