Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Don't unconditionally clear all index zone configs when transitioning to REGIONAL BY ROW #63614

Closed
ajstorm opened this issue Apr 14, 2021 · 0 comments · Fixed by #63665
Closed
Assignees
Labels
A-multiregion Related to multi-region C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@ajstorm
Copy link
Collaborator

ajstorm commented Apr 14, 2021

Currently we drop all of the index zone configs when transitioning to REGIONAL BY ROW. The problem however, is if the user's created a zone configuration on one of the indexes to set a non-multi-region field, we'll blow away that change too. This issue should take a more subtle approach in dropZoneConfigsForMultiRegionIndexes and only clear out the zone configurations for indexes if they have multi-region fields set.

We'd want this test to work:

  • create a RBR table with a secondary index
  • set gc.ttlseconds and num_replicas on the index
  • set override = true
  • change locality to GLOBAL
  • ensure the gc.ttlseconds is still on the index
@ajstorm ajstorm added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-multiregion Related to multi-region labels Apr 14, 2021
@ajstorm ajstorm self-assigned this Apr 14, 2021
@craig craig bot closed this as completed in ccec109 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-multiregion Related to multi-region C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant