Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Drop zone configurations on indexes that will be GCed, to avoid problems in the GC path #62029

Closed
ajstorm opened this issue Mar 15, 2021 · 1 comment · Fixed by #62421
Closed
Assignees
Labels
A-schema-changes C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker

Comments

@ajstorm
Copy link
Collaborator

ajstorm commented Mar 15, 2021

#61751 identified an issue where indexes which were queued for GC (in that case, because of a PK change) would still have their zone configs intact. This caused a problem in the index GC code as the necessary infrastructure wasn't in-place to drop the zone configurations at GC time and a panic ensued. #61751 addressed this problem, specifically for REGIONAL BY ROW tables, by cleaning up the zone configurations as part of the schema change job which queued up the index for GC.

We need a more general fix however, for tables which can get into this state organically (i.e. not through the use of the new MR abstractions).

Since this issue has the potential to bring down a node in the index GC job, I'm marking it as a 21.1 GA blocker.

@ajstorm ajstorm added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-schema-changes GA-blocker branch-release-21.1 labels Mar 15, 2021
@ajwerner
Copy link
Contributor

This is a newly important bug because we did not support partitioning by user-defined types in 20.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-schema-changes C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants