Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: sqlsmith/setup=seed/setting=no-mutations failed #61587

Closed
cockroach-teamcity opened this issue Mar 6, 2021 · 1 comment
Closed
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). GA-blocker O-roachtest O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).sqlsmith/setup=seed/setting=no-mutations failed on master@15a185606d5e80b47d9fdd0ed4f54cfe29c527c6:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/sqlsmith/setup=seed/setting=no-mutations/run_1
	sqlsmith.go:198,sqlsmith.go:228,test_runner.go:767: error: pq: internal error: crdb_internal.show_create_all_tables(): crdb_internal.show_create_all_tables: unexpected batch read timestamp: 1615016939.579540000,0. Expected refreshed timestamp: 1615016939.578755175,0. ba: Scan [/Table/3/1,/Table/3/2), [txn: acfa5223]. txn: "sql txn" meta={id=acfa5223 pri=0.07530153 epo=0 ts=1615016939.579540000,0 min=1615016939.578755175,0 seq=0} lock=false stat=PENDING rts=1615016939.579540000,0 wto=false gul=1615016939.579540000,0
		stmt:
		SELECT
			948318544:::INT8 AS col_23538, crdb_internal.show_create_all_tables(tab_9763._string::STRING)::STRING AS col_23539
		FROM
			defaultdb.public.seed@[0] AS tab_9763
		LIMIT
			32:::INT8;

More

Artifacts: /sqlsmith/setup=seed/setting=no-mutations

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 6, 2021
@dt dt added GA-blocker and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 8, 2021
@RichardJCai
Copy link
Contributor

This should no longer be valid as show_create_all_tables_builtin was refactored on master
#61127

E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).execInternal.func1.1
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | 	/go/src/github.com/cockroachdb/cockroach/pkg/sql/internal.go:658
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | github.com/cockroachdb/cockroach/pkg/sql.(*rowsIterator).Next.func1
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | 	/go/src/github.com/cockroachdb/cockroach/pkg/sql/internal.go:273
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | github.com/cockroachdb/cockroach/pkg/sql.(*rowsIterator).Next
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | 	/go/src/github.com/cockroachdb/cockroach/pkg/sql/internal.go:313
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | github.com/cockroachdb/cockroach/pkg/sql.(*rowsIterator).Next
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | 	/go/src/github.com/cockroachdb/cockroach/pkg/sql/internal.go:306
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | github.com/cockroachdb/cockroach/pkg/sql/sem/builtins.getTableNames
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | 	/go/src/github.com/cockroachdb/cockroach/pkg/sql/sem/builtins/show_create_all_tables_builtin.go:278
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | github.com/cockroachdb/cockroach/pkg/sql/sem/builtins.getMetadataForTablesInDB
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | 	/go/src/github.com/cockroachdb/cockroach/pkg/sql/sem/builtins/show_create_all_tables_builtin.go:129
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | github.com/cockroachdb/cockroach/pkg/sql/sem/builtins.showCreateAllTablesBuiltin
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | 	/go/src/github.com/cockroachdb/cockroach/pkg/sql/sem/builtins/show_create_all_tables_builtin.go:49
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec.(*defaultBuiltinFuncOperator).Next.func1
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | 	/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexec/builtin_funcs.go:83
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | github.com/cockroachdb/cockroach/pkg/sql/colmem.(*Allocator).PerformOperation
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | 	/go/src/github.com/cockroachdb/cockroach/pkg/sql/colmem/allocator.go:298
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec.(*defaultBuiltinFuncOperator).Next
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | 	/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexec/builtin_funcs.go:61
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecbase.(*simpleProjectOp).Next
E210306 07:48:59.582022 2313 sql/sqltelemetry/report.go:57 ⋮ [n1,client=‹35.229.26.254:60634›,hostnossl,user=root] 723 +  | 	/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexec/colexecbase/simple_project.go:124

Looking at the stack getTableNames is called before the crash, that function was removed.

Will reopen if we see this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). GA-blocker O-roachtest O-robot Originated from a bot.
Projects
None yet
Development

No branches or pull requests

3 participants