Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colexec: v20.2.4: mismatched types with UNION #61462

Closed
cockroach-teamcity opened this issue Mar 4, 2021 · 3 comments
Closed

colexec: v20.2.4: mismatched types with UNION #61462

cockroach-teamcity opened this issue Mar 4, 2021 · 3 comments
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-sentry Originated from an in-the-wild panic report.

Comments

@cockroach-teamcity
Copy link
Member

This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry link: https://sentry.io/organizations/cockroach-labs/issues/2252077828/?referrer=webhooks_plugin

Panic message:

error.go:90: unexpected error from the vectorized engine: ×
--
*barriers.barrierError
*errutil.withPrefix: unexpected error from the vectorized engine (1)
error.go:90: *withstack.withStack (top exception)
*assert.withAssertionFailure
*colexecerror.notInternalError
*colexecerror.notInternalError
*colexecerror.notInternalError
*contexttags.withContext: n1 (2)
*contexttags.withContext: n2 (3)
*colexecerror.notInternalError
inbox.go:248: *withstack.withStack (4)
*colexecerror.notInternalError
*colexecerror.notInternalError
*colexecerror.notInternalError
*contexttags.withContext: n2 (5)
*contexttags.withContext: n1 (6)
*colexecerror.notInternalError
inbox.go:248: *withstack.withStack (7)
*colexecerror.notInternalError
(check the extra data payloads)

Stacktrace (expand for inline code snippets):

i.close()
colexecerror.InternalError(log.PanicAsError(0, err))
}
in pkg/sql/colflow/colrpc.(*Inbox).Next.func1
/usr/local/go/src/runtime/panic.go#L678-L680 in runtime.gopanic
func ExpectedError(err error) {
panic(newNotInternalError(err))
}
in pkg/sql/colexecbase/colexecerror.ExpectedError
// DrainMeta.
colexecerror.ExpectedError(meta.Err)
}
in pkg/sql/colflow/colrpc.(*Inbox).Next
return func() {
s.batches[inputIdx] = input.Op.Next(ctx)
}
in pkg/sql/colexec.(*ParallelUnorderedSynchronizer).init.func1.1
}()
operation()
return retErr
in pkg/sql/colexecbase/colexecerror.CatchVectorizedRuntimeError
case parallelUnorderedSynchronizerStateRunning:
if err := colexecerror.CatchVectorizedRuntimeError(s.nextBatch[inputIdx]); err != nil {
sendErr(err)
in pkg/sql/colexec.(*ParallelUnorderedSynchronizer).init.func2
/usr/local/go/src/runtime/asm_amd64.s#L1356-L1358 in runtime.goexit

pkg/sql/colflow/colrpc/inbox.go in pkg/sql/colflow/colrpc.(*Inbox).Next.func1 at line 248
/usr/local/go/src/runtime/panic.go in runtime.gopanic at line 679
pkg/sql/colexecbase/colexecerror/error.go in pkg/sql/colexecbase/colexecerror.ExpectedError at line 186
pkg/sql/colflow/colrpc/inbox.go in pkg/sql/colflow/colrpc.(*Inbox).Next at line 289
pkg/sql/colexec/parallel_unordered_synchronizer.go in pkg/sql/colexec.(*ParallelUnorderedSynchronizer).init.func1.1 at line 195
pkg/sql/colexecbase/colexecerror/error.go in pkg/sql/colexecbase/colexecerror.CatchVectorizedRuntimeError at line 93
pkg/sql/colexec/parallel_unordered_synchronizer.go in pkg/sql/colexec.(*ParallelUnorderedSynchronizer).init.func2 at line 229
/usr/local/go/src/runtime/asm_amd64.s in runtime.goexit at line 1357
Tag Value
Cockroach Release v20.2.4
Cockroach SHA: eda2309
Platform linux amd64
Distribution CCL
Environment v20.2.4
Command server
Go Version ``
# of CPUs
# of Goroutines
@cockroach-teamcity cockroach-teamcity added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-sentry Originated from an in-the-wild panic report. labels Mar 4, 2021
This was referenced Mar 4, 2021
@yuzefovich
Copy link
Member

Mismatched types:

/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexecbase/colexecerror/error.go in func1 at line 90
/usr/local/go/src/runtime/panic.go in gopanic at line 679
/usr/local/go/src/runtime/iface.go in panicdottypeE at line 255
/go/src/github.com/cockroachdb/cockroach/pkg/col/coldata/vec.go in Int32 at line 222
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexec/ordered_synchronizer.eg.go in func1 at line 181
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colmem/allocator.go in PerformOperation at line 286
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexec/ordered_synchronizer.eg.go in Next at line 126
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexec/operator.go in Next at line 238
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexec/operator.go in Next at line 458
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexec/buffer.go in advance at line 62
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexec/case.go in Next at line 113

The query fingerprint isn't full, so the issue is unactionable. I'm hoping it is a dup of #59148.

@yuzefovich yuzefovich reopened this Mar 4, 2021
@yuzefovich
Copy link
Member

Actually, I take it back - possibly we have a problem of different type projections in CASE (when and else arms). Needs further investigation.

@yuzefovich yuzefovich changed the title sentry: error.go:90: unexpected error from the vectorized engine: × -- *barriers.barrierError *errutil.withPrefix: unexpected error from the vectorized engine (1) error.go:90: *withstack.withStack (top exception) *assert.withAssertionFailure *colexecerror.notInternalError *colexecerror.notInternalError *colexecerror.notInternalError *contexttags.withContext: n1 (2) *contexttags.withContext: n2 (3) *colexecerror.notInternalError inbox.go:248: *withstack.withStack (4) *colexecerror.notInternalError *colexecerror.notInternalError *colexecerror.notInternalError *contexttags.withContext: n2 (5) *contexttags.withContext: n1 (6) *colexecerror.notInternalError inbox.go:248: *withstack.withStack (7) *colexecerror.notInternalError (check the extra data payloads) colexec: v20.2.4: mismatched types in CASE Mar 4, 2021
This was referenced Mar 4, 2021
@yuzefovich
Copy link
Member

I examined the vectorized CASE planning code, and we do plan the casts if there is a mismatch between the CASE output type and each of THEN projection arms, so I believe it is a dup of #59148.

@yuzefovich yuzefovich changed the title colexec: v20.2.4: mismatched types in CASE colexec: v20.2.4: mismatched types with UNION Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-sentry Originated from an in-the-wild panic report.
Projects
None yet
Development

No branches or pull requests

2 participants