Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: the intercept mechanism prevents entries from being emitted to logging #61335

Closed
knz opened this issue Mar 2, 2021 · 0 comments · Fixed by #61378
Closed

log: the intercept mechanism prevents entries from being emitted to logging #61335

knz opened this issue Mar 2, 2021 · 0 comments · Fixed by #61378
Assignees
@miretskiy
Labels
A-cc-enablement Pertains to current CC production issues or short-term projects A-logging In and around the logging infrastructure. A-security C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Mar 2, 2021

When the user enables "logspy", i.e. injects a logging interceptor, the entries are passed to the interceptor and do not go to the log file any more.

This makes any log entry disappear entirely. Including all the audit logging which is required for security purpose.

We must change the logspy / intercept mechanism to have "tee" behavior and let the entries continue to go to log files or other sinks.

Found by @miretskiy

cc @aaron-crl @tbg
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-security A-logging In and around the logging infrastructure. labels Mar 2, 2021
@miretskiy miretskiy self-assigned this Mar 2, 2021
@miretskiy miretskiy mentioned this issue Mar 2, 2021
Merged
@craig craig bot closed this as completed in 7a68e6e Jun 10, 2021
@knz knz added the A-cc-enablement Pertains to current CC production issues or short-term projects label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miretskiy miretskiy

Labels
A-cc-enablement Pertains to current CC production issues or short-term projects A-logging In and around the logging infrastructure. A-security C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log,debug: fix logspy, new HTTP API to change vmodule miretskiy/cockroach
2 participants
@knz @miretskiy