-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: PREPARE q AS DROP TYPE typ causes an internal error #61226
Comments
rafiss
added
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
S-3
Medium-low impact: incurs increased costs for some users (incl lower avail, recoverable bad data)
labels
Feb 27, 2021
tharun208
added a commit
to tharun208/cockroach
that referenced
this issue
Mar 3, 2021
Release justification: fixes for high-priority or high-severity bugs in existing functionality Previously, prepare statement doesnt have support for drop type in optimizer, so it panic during execution as no flags are generated. This patch fixes this by adding dropType to the optimizer. Resolves cockroachdb#61226 Release note: none Signed-off-by: Tharun <[email protected]>
tharun208
added a commit
to tharun208/cockroach
that referenced
this issue
Mar 3, 2021
Release justification: fixes for high-priority or high-severity bugs in existing functionality Previously, prepare statement doesnt have support for drop type in optimizer, so it panic during execution as no flags are generated. This patch fixes this by adding dropType to the optimizer. Resolves cockroachdb#61226 Release note: none Signed-off-by: Tharun <[email protected]>
tharun208
added a commit
to tharun208/cockroach
that referenced
this issue
Mar 3, 2021
Release justification: fixes for high-priority or high-severity bugs in existing functionality Previously, prepare statement doesnt have support for drop type in optimizer, so it panic during execution as no flags are generated. This patch fixes this by adding dropType to the optimizer. Resolves cockroachdb#61226 Release note: none Signed-off-by: Tharun <[email protected]>
tharun208
added a commit
to tharun208/cockroach
that referenced
this issue
Mar 4, 2021
Release justification: fixes for high-priority or high-severity bugs in existing functionality Previously, prepare statement doesnt have support for drop type in optimizer, so it panic during execution as no flags are generated. This patch fixes this by adding dropType to the optimizer. Resolves cockroachdb#61226 Release note: none Signed-off-by: Tharun <[email protected]>
craig bot
pushed a commit
that referenced
this issue
Mar 4, 2021
61394: sql: add drop type to the prepared statement generator r=rafiss a=tharun208 Release justification: fixes for high-priority or high-severity bugs in existing functionality Previously, prepare statement doesn't have support for drop type in the optimizer, so it panics during execution as no flags are generated. This patch fixes this by adding `dropType` to the optimizer. Resolves #61226 Release note: none Signed-off-by: Tharun <[email protected]> <img width="454" alt="Screen Shot 2021-03-03 at 2 39 29 PM" src="https://user-images.githubusercontent.com/14926492/109781995-6c2a8d80-7c2e-11eb-902e-e596aa4f2bb3.png"> 61437: sql: block interleaved tables with REGIONAL BY ROW r=ajstorm a=otan Release justification: Low-risk change to new functionality. Release note: None 61449: sql: fix UNIQUE column definition for REGIONAL BY ROW r=rytaft a=otan This was buggy as the implicitly added crdb_region column was not initialized before the UNIQUE definition was available. Instead, defer these index creations until after all column definitions have been initialized. Release justification: low-risk bug fix to new functionality Release note: None Co-authored-by: Tharun <[email protected]> Co-authored-by: Oliver Tan <[email protected]>
This was referenced Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is affecting master right now, and is causing Random Syntax Tests to fail: https://teamcity.cockroachdb.com/viewLog.html?buildId=2725105&buildTypeId=Cockroach_Nightlies_RandomSyntaxTests
It seems like the issue is that
planner.Annotations()
is nil when callingconnExecutor.addPreparedStmt()
.Repro:
The text was updated successfully, but these errors were encountered: