Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: generator builtin close() method does not surface errors #61123

Open
angelapwen opened this issue Feb 25, 2021 · 1 comment
Open

sql: generator builtin close() method does not surface errors #61123

angelapwen opened this issue Feb 25, 2021 · 1 comment
Labels
A-sql-executor SQL txn logic C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team

Comments

@angelapwen
Copy link

angelapwen commented Feb 25, 2021

Describe the problem
In creating a SQL generator method, we use the tree.ValueGenerator interface. Its Close() method currently does not have a return value.

This poses a problem when using the new Internal Executor's streaming iterator pattern (added in #59330) to generate builtin function. Its Close() method must be called to close the iterator and returns an error, but this error cannot be surfaced in the generator builtin caller (and the iterator may potentially be left open).

This problem was originally discussed in context of #60922: link

Jira issue: CRDB-3064

@angelapwen angelapwen added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-executor SQL txn logic labels Feb 25, 2021
@jlinder jlinder added the T-sql-queries SQL Queries Team label Jun 16, 2021
@yuzefovich yuzefovich removed their assignment May 31, 2022
@mgartner mgartner moved this to Backlog (DO NOT ADD NEW ISSUES) in SQL Queries Jul 24, 2023
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@yuzefovich yuzefovich moved this from Backlog (DO NOT ADD NEW ISSUES) to Bugs to Fix in SQL Queries Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-executor SQL txn logic C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team
Projects
Status: Bugs to Fix
Development

No branches or pull requests

3 participants