sql: generator builtin close() method does not surface errors #61123
Labels
A-sql-executor
SQL txn logic
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-sql-queries
SQL Queries Team
Describe the problem
In creating a SQL generator method, we use the
tree.ValueGenerator
interface. ItsClose()
method currently does not have a return value.This poses a problem when using the new Internal Executor's streaming iterator pattern (added in #59330) to generate builtin function. Its
Close()
method must be called to close the iterator and returns an error, but this error cannot be surfaced in the generator builtin caller (and the iterator may potentially be left open).This problem was originally discussed in context of #60922: link
Jira issue: CRDB-3064
The text was updated successfully, but these errors were encountered: