Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: goroutine spawned for vtable generators does not go through stopper #60587

Closed
knz opened this issue Feb 15, 2021 · 1 comment · Fixed by #61540
Closed

sql: goroutine spawned for vtable generators does not go through stopper #60587

knz opened this issue Feb 15, 2021 · 1 comment · Fixed by #61540
Assignees
Labels
A-error-handling Error messages, error propagations/annotations A-sql-execution Relating to SQL execution. A-sql-executor SQL txn logic C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Feb 15, 2021

The code in sql/virtual_table.go contains the following:

  wg.Add(1)
  go func() {
    defer wg.Done()
  ...

it should use the stopper and run an Async task instead

or alternatively share the goroutine registration stuff with the stopper to get the cancellation behavior upon server stop.

at the very least it needs a call to logcrash.RecoverOnPanic...

@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-execution Relating to SQL execution. A-sql-executor SQL txn logic A-error-handling Error messages, error propagations/annotations labels Feb 15, 2021
@knz
Copy link
Contributor Author

knz commented Feb 15, 2021

cc @yuzefovich @rafiss for triage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-error-handling Error messages, error propagations/annotations A-sql-execution Relating to SQL execution. A-sql-executor SQL txn logic C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants