Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backup: ExportRequest should run with high-priority, even with WaitPolicy_Error #59811

Closed
nvanbenschoten opened this issue Feb 4, 2021 · 1 comment
Closed

backup: ExportRequest should run with high-priority, even with WaitPolicy_Error #59811

nvanbenschoten opened this issue Feb 4, 2021 · 1 comment
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@nvanbenschoten
Copy link
Member

This would allow the ExportRequest to skip the kv.lock_table.coordinator_liveness_push_delay, which would allow it to clean up abandoned intents much more quickly.

We should confirm that this helps with the test discussed in #59704.
@nvanbenschoten nvanbenschoten added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-disaster-recovery labels Feb 4, 2021
@nvanbenschoten
Copy link
Member Author

Actually, I don't think this is needed. We don't wait out the kv.lock_table.coordinator_liveness_push_delay for requests with a WaitPolicy of WaitPolicy_Error:

cockroach/pkg/kv/kvserver/concurrency/lock_table_waiter.go

Line 159 in 10292a7

if req.WaitPolicy == lock.WaitPolicy_Error {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nvanbenschoten