Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logictestccl: flake in the zone config tests due to non-determinisgm in SHOW CREATE #59644

Closed
knz opened this issue Feb 1, 2021 · 1 comment
Labels
A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Feb 1, 2021

Found in https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_UnitTests/2628156?

expected:
[...]
ALTER PARTITION p1 OF INDEX test.public.t@i1 CONFIGURE ZONE USING
gc.ttlseconds = 15210;
ALTER PARTITION p2 OF INDEX test.public.t@i1 CONFIGURE ZONE USING
gc.ttlseconds = 15213;
ALTER PARTITION p3 OF INDEX test.public.t@i2 CONFIGURE ZONE USING
gc.ttlseconds = 15411;
ALTER PARTITION p4 OF INDEX test.public.t@i2 CONFIGURE ZONE USING
gc.ttlseconds = 15418

but found (query options: "") :
[...]
ALTER PARTITION p3 OF INDEX test.public.t@i2 CONFIGURE ZONE USING
gc.ttlseconds = 15411;
ALTER PARTITION p4 OF INDEX test.public.t@i2 CONFIGURE ZONE USING
gc.ttlseconds = 15418;
ALTER PARTITION p1 OF INDEX test.public.t@i1 CONFIGURE ZONE USING
gc.ttlseconds = 15210;
ALTER PARTITION p2 OF INDEX test.public.t@i1 CONFIGURE ZONE USING
gc.ttlseconds = 15213

Observe: the partitions are reported in a different order. This suggests that the output of SHOW CREATE is non-determinisitc when there are partitions.

cc @RaduBerinde @otan for triage.

@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-testing Testing tools and infrastructure labels Feb 1, 2021
@knz
Copy link
Contributor Author

knz commented Feb 1, 2021

Fixed by #59580 (yesterday, which is why I hadn't noticed earlier)

@knz knz closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

No branches or pull requests

1 participant