Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: export requests slowly clear abandoned intents #59599

Closed
pbardea opened this issue Jan 29, 2021 · 1 comment
Closed

backupccl: export requests slowly clear abandoned intents #59599

pbardea opened this issue Jan 29, 2021 · 1 comment
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@pbardea
Copy link
Contributor

pbardea commented Jan 29, 2021

In the case that an export request runs into a lot of abandoned intents, it will attempt to clean them up one at a time. In comparison, ScanRequests collect intents to clean up (

cockroach/pkg/kv/kvserver/batcheval/cmd_scan.go

Line 83 in 22a46b1

reply.IntentRows, err = CollectIntentRows(ctx, reader, usePrefixIter, scanRes.Intents)
). This could lead to backups slowing down dramatically when running into a large swath of abandoned intents.
@pbardea pbardea added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-disaster-recovery labels Jan 29, 2021
@pbardea
Copy link
Contributor Author

pbardea commented Feb 4, 2021

Closing this as a duplicate of #59704

@pbardea pbardea closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbardea