Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add metric for full index/table scans #58653

Closed
jordanlewis opened this issue Jan 8, 2021 · 1 comment · Fixed by #59261
Closed

sql: add metric for full index/table scans #58653

jordanlewis opened this issue Jan 8, 2021 · 1 comment · Fixed by #59261
Assignees
@barryhe2000
Labels
A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members.

Comments

@jordanlewis
Copy link
Member

Add a new metric for full index and table scans, called sql.full_index_scans. Increment this metric when a full table or index scan is performed by a user-initiated query.

This should probably happen in the same spot that we add them to the slow query logs.
@jordanlewis jordanlewis added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members. A-sql-observability Related to observability of the SQL layer labels Jan 8, 2021
@jordanlewis
Copy link
Member Author

Earmarking this for Barry.

@barryhe2000 barryhe2000 mentioned this issue Jan 21, 2021
Merged
@craig craig bot closed this as completed in 054c618 Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barryhe2000 barryhe2000

Labels
A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add full table or index scan count metric barryhe2000/cockroach
2 participants
@jordanlewis @barryhe2000