Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: ALTER VIEW/SEQUENCE .. OWNER TO is not implemented #57965

Closed
knz opened this issue Dec 15, 2020 · 4 comments · Fixed by #59049
Closed

sql: ALTER VIEW/SEQUENCE .. OWNER TO is not implemented #57965

knz opened this issue Dec 15, 2020 · 4 comments · Fixed by #59049
Assignees
@RichardJCai
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-privileges SQL privilege handling and permission checks. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.

Comments

@knz
Copy link
Contributor

knz commented Dec 15, 2020 •
edited
Loading

This is implemented in postgres.

Also, postgres allows using ALTER TABLE ... OWNER TO to change the ownership of a view or sequence -- it's not restricted to tables. In CockroachDB, this currently produces an error.
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-pgcompat Semantic compatibility with PostgreSQL S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. A-sql-privileges SQL privilege handling and permission checks. labels Dec 15, 2020
@knz
Copy link
Contributor Author

knz commented Dec 15, 2020

cc @piyush-singh @vy-ton @solongordon for triage

@knz knz changed the title sql: ALTER VIEW .. OWNER TO is not implemented sql: ALTER VIEW/SEQUENCE .. OWNER TO is not implemented Dec 15, 2020
@knz
Copy link
Contributor Author

knz commented Dec 15, 2020

Also obviously this is also missing structured event logging. cc @thtruo

@knz
Copy link
Contributor Author

knz commented Dec 22, 2020

FWIW this does not have an immediate security impact, but we may want to prioritize this for the sake of consistent UX.

@solongordon
Copy link
Contributor

Thanks @knz, looks like it could be a good "welcome back" starter project for @RichardJCai next week.

@vy-ton vy-ton mentioned this issue Jan 5, 2021
Closed
@RichardJCai RichardJCai self-assigned this Jan 13, 2021
@RichardJCai RichardJCai mentioned this issue Jan 15, 2021
Merged
@craig craig bot closed this as completed in 47eb9f3 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RichardJCai RichardJCai

Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-privileges SQL privilege handling and permission checks. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: implement alter sequence/view owner RichardJCai/cockroach
3 participants
@knz @solongordon @RichardJCai