Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hlc: panic on update with synthetic timestamp #57684

Closed
nvanbenschoten opened this issue Dec 8, 2020 · 0 comments · Fixed by #58349
Closed

hlc: panic on update with synthetic timestamp #57684

nvanbenschoten opened this issue Dec 8, 2020 · 0 comments · Fixed by #58349
Assignees
@nvanbenschoten
Labels
A-kv-transactions Relating to MVCC and the transactional model. A-multiregion Related to multi-region C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@nvanbenschoten
Copy link
Member

Needed for non-blocking transactions: #52745.

An HLC clock should never be updated with a synthetic timestamp. This is part of how we will validate that we are keeping the clock time domain and the transaction time domain separate.
@nvanbenschoten nvanbenschoten added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-transactions Relating to MVCC and the transactional model. A-multiregion Related to multi-region T-multiregion labels Dec 8, 2020
@nvanbenschoten nvanbenschoten self-assigned this Dec 8, 2020
@nvanbenschoten nvanbenschoten mentioned this issue Jan 5, 2021
Merged
@craig craig bot closed this as completed in a148c4f Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvanbenschoten nvanbenschoten

Labels
A-kv-transactions Relating to MVCC and the transactional model. A-multiregion Related to multi-region C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hlc: strongly type ClockTimestamp as specialization of Timestamp nvanbenschoten/cockroach
1 participant
@nvanbenschoten