Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: simplify the management of merges with log-drives closed timestamps #57408

Closed
andreimatei opened this issue Dec 2, 2020 · 1 comment
Closed

kvserver: simplify the management of merges with log-drives closed timestamps #57408

andreimatei opened this issue Dec 2, 2020 · 1 comment
Assignees
@andreimatei
Labels
A-kv-closed-timestamps Relating to closed timestamps A-multiregion Related to multi-region C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@andreimatei
Copy link
Contributor

Currently the merge code does something real' funky for preventing closed timestamps from advancing on a subsumed range (i.e. a RHS in the process of being merged). We feed the tracker a bogus command at a future LAI, which is expected to never come in case the merge succeeds.
With log-drives closed timestamps, this will no longer be necessary. The only thing we need to take care of is to exclude a subsumed range from the side transport for inactive ranges.
@andreimatei andreimatei added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multiregion Related to multi-region A-kv-closed-timestamps Relating to closed timestamps labels Dec 2, 2020
@andreimatei andreimatei self-assigned this Dec 2, 2020
@aayushshah15 aayushshah15 mentioned this issue Feb 1, 2021
Closed
@nvanbenschoten
Copy link
Member

Resolved by #61221 and #61137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreimatei andreimatei

Labels
A-kv-closed-timestamps Relating to closed timestamps A-multiregion Related to multi-region C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kenliu @andreimatei @nvanbenschoten