Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Add telemetry for materialized views #57299

Closed
vy-ton opened this issue Dec 1, 2020 · 4 comments · Fixed by #59201
Closed

sql: Add telemetry for materialized views #57299

vy-ton opened this issue Dec 1, 2020 · 4 comments · Fixed by #59201
Assignees
Labels
A-telemetry C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@vy-ton
Copy link
Contributor

vy-ton commented Dec 1, 2020

We are missing 20.2 telemetry for materialized views.

@blathers-crl
Copy link

blathers-crl bot commented Dec 1, 2020

Hi @vy-ton, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@rafiss rafiss added A-telemetry C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Dec 1, 2020
@rafiss rafiss self-assigned this Dec 1, 2020
@vy-ton
Copy link
Contributor Author

vy-ton commented Jan 6, 2021

@solongordon Can we make sure this gets prioritized for Milestone D?

@rafiss
Copy link
Collaborator

rafiss commented Jan 12, 2021

@RichardJCai will take over this issue.

@otan may have seen telemetry for this. Need more information on which specific things need to be tracked. (What name should it reported under? When should the feature counter be incremented?)

@rafiss rafiss removed their assignment Jan 12, 2021
@vy-ton
Copy link
Contributor Author

vy-ton commented Jan 12, 2021

Feature counters can be incremented for the following commands. The existing counters for views are prefixed with sql.schema.create_view so we can use sql.schema.x_materialized_view

CREATE MATERIALIZED VIEW
REFRESH MATERIALIZED VIEW
ALTER MATERIALIZED VIEW
DROP MATERIALIZED VIEW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-telemetry C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants