Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: regression test MovR #56922

Closed
awoods187 opened this issue Nov 19, 2020 · 5 comments
Closed

sql: regression test MovR #56922

awoods187 opened this issue Nov 19, 2020 · 5 comments
Assignees
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) C-performance Perf of queries or internals. Solution not expected to change functional behavior. no-issue-activity T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) X-stale

Comments

@awoods187
Copy link
Contributor

awoods187 commented Nov 19, 2020

MovR is an important sample workload that we ship in our workload package for demos, use in education (e.g., documentation, training), and encourage SE use for customer demos. However, we don't regularly run tests against MovR to ensure that workload doesn't regress with changes to CockroachDB. We need to invest the same rigor of performance tests as we do with other benchmarks like TPC-C and TPC-H to ensure that MovR always works well for our end customers.

Examples of issues include this or this slack conversation.

Jira issue: CRDB-2892

@awoods187 awoods187 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) C-performance Perf of queries or internals. Solution not expected to change functional behavior. labels Nov 19, 2020
@awoods187
Copy link
Contributor Author

cc @jordanlewis @vy-ton @nstewart

@nstewart
Copy link
Contributor

Also this example from 20.1 - #49658

@rafiss
Copy link
Collaborator

rafiss commented Nov 24, 2020

We can add a nightly test that executes the steps of the Movr demo. The demo script is here https://github.com/cockroachlabs/scripted-demos/blob/master/geo-partitioned-replicas-demo.sh

We won't be able to commit to fixing all the issues that come up with this test, since there's such a broad range of features in the demo, but hopefully this is a good starting point for catching regressions and routing them to the correct team.

@vy-ton
Copy link
Contributor

vy-ton commented Mar 12, 2021

@rafiss @solongordon Can we add this for 21.1 stability or a quality initiative for 21.2?

@rafiss rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 5, 2021
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) C-performance Perf of queries or internals. Solution not expected to change functional behavior. no-issue-activity T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) X-stale
Projects
None yet
Development

No branches or pull requests

5 participants