Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: leaked stopper in TestPanicWithNilSender #56697

Closed
knz opened this issue Nov 14, 2020 · 1 comment · Fixed by #56698
Closed

client: leaked stopper in TestPanicWithNilSender #56697

knz opened this issue Nov 14, 2020 · 1 comment · Fixed by #56698
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Nov 14, 2020

    stopper.go:98: leaked stopper, created at:
        goroutine 47 [running]:
        runtime/debug.Stack(0xc00008be60, 0x41d1b8, 0x30)
                /usr/local/go/src/runtime/debug/stack.go:24 +0x9f
        github.com/cockroachdb/cockroach/pkg/util/stop.register(0xc000416000)
                /go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:52 +0x45
        github.com/cockroachdb/cockroach/pkg/util/stop.NewStopper(0x0, 0x0, 0x0, 0x24b0400)
                /go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:189 +0x1ca
        github.com/cockroachdb/cockroach/pkg/internal/client/requestbatcher.TestPanicWithNilSender(0xc00048dc80)
                /go/src/github.com/cockroachdb/cockroach/pkg/internal/client/requestbatcher/batcher_test.go:556 +0xa5
        testing.tRunner(0xc00048dc80, 0x1990b98)
                /usr/local/go/src/testing/testing.go:1123 +0xef
        created by testing.(*T).Run
                /usr/local/go/src/testing/testing.go:1168 +0x2b3
@knz knz self-assigned this Nov 14, 2020
@blathers-crl
Copy link

blathers-crl bot commented Nov 14, 2020

Hi @knz, I've guessed the C-ategory of your issue and suitably labeled it. Please re-label if inaccurate.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Nov 14, 2020
@craig craig bot closed this as completed in e7e0f26 Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant