Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: stopper leak in TestStoreRangeMergeDuringShutdown #56696

Closed
knz opened this issue Nov 14, 2020 · 0 comments · Fixed by #56698
Closed

kvserver: stopper leak in TestStoreRangeMergeDuringShutdown #56696

knz opened this issue Nov 14, 2020 · 0 comments · Fixed by #56698
Assignees
@knz
Labels
A-kv-replication Relating to Raft, consensus, and coordination. A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Nov 14, 2020

Found this while working on an unrelated issue:

    stopper.go:98: leaked stopper, created at:
        goroutine 167326 [running]:
        runtime/debug.Stack(0xc005464f48, 0x428998, 0x30)
                /usr/local/go/src/runtime/debug/stack.go:24 +0x9f
        github.com/cockroachdb/cockroach/pkg/util/stop.register(0xc006b08240)
                /go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:52 +0x45
        github.com/cockroachdb/cockroach/pkg/util/stop.NewStopper(0x0, 0x0, 0x0, 0xc0059106d8)
                /go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:189 +0x1ca
        github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.(*multiTestContext).Start(0xc00724c000, 0x5530120, 0xc003384000, 0x1)
                /go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/client_test.go:373 +0xb5f
        github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.TestStoreRangeMergeDuringShutdown(0xc003384000)
                /go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/client_merge_test.go:3403 +0x28a
        testing.tRunner(0xc003384000, 0x4d55b88)
                /usr/local/go/src/testing/testing.go:1123 +0xef
        created by testing.(*T).Run
                /usr/local/go/src/testing/testing.go:1168 +0x2b3
    stopper.go:98: leaked stopper, created at:
        goroutine 167326 [running]:
        runtime/debug.Stack(0xc00041e418, 0x428998, 0x30)
                /usr/local/go/src/runtime/debug/stack.go:24 +0x9f
        github.com/cockroachdb/cockroach/pkg/util/stop.register(0xc006b082d0)
                /go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:52 +0x45
        github.com/cockroachdb/cockroach/pkg/util/stop.NewStopper(0x0, 0x0, 0x0, 0x0)
                /go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:189 +0x1ca
        github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.(*multiTestContext).addStore(0xc00724c000, 0x0)
                /go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/client_test.go:872 +0x1d5c
        github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.(*multiTestContext).Start(0xc00724c000, 0x5530120, 0xc003384000, 0x1)
                /go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/client_test.go:409 +0x865
        github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.TestStoreRangeMergeDuringShutdown(0xc003384000)
                /go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/client_merge_test.go:3403 +0x28a
        testing.tRunner(0xc003384000, 0x4d55b88)
                /usr/local/go/src/testing/testing.go:1123 +0xef
        created by testing.(*T).Run
                /usr/local/go/src/testing/testing.go:1168 +0x2b3
FAIL    github.com/cockroachdb/cockroach/pkg/kv/kvserver        90.292s
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-kv-replication Relating to Raft, consensus, and coordination. A-testing Testing tools and infrastructure labels Nov 14, 2020
@knz knz self-assigned this Nov 14, 2020
@knz knz mentioned this issue Nov 14, 2020
Merged
@craig craig bot closed this as completed in e7e0f26 Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-kv-replication Relating to Raft, consensus, and coordination. A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stopper: assert that stoppers don't leak knz/cockroach
1 participant
@knz