Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execstats: calculate total rows/bytes read from KV #56605

Closed
asubiotto opened this issue Nov 12, 2020 · 0 comments · Fixed by #57495
Closed

execstats: calculate total rows/bytes read from KV #56605

asubiotto opened this issue Nov 12, 2020 · 0 comments · Fixed by #57495
Assignees
@cathymw
Labels
A-sql-execution Relating to SQL execution. A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@asubiotto
Copy link
Contributor

This issue tracks adding the calculation of both total bytes and total rows read from KV to the TraceAnalyzer. This information is already surfaced to the admin UI in the statements page based on the infrastructure to calculate progress. This issue simply tracks adding this calculation from the physical plan + trace to the TraceAnalyzer in case of need in other cases (e.g. annotating the textual explain analyze plan with this information).
@asubiotto asubiotto added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-execution Relating to SQL execution. A-sql-observability Related to observability of the SQL layer labels Nov 12, 2020
@asubiotto asubiotto mentioned this issue Nov 12, 2020
Closed
7 tasks
@cathymw cathymw mentioned this issue Dec 3, 2020
Merged
@craig craig bot closed this as completed in 1697431 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cathymw cathymw

Labels
A-sql-execution Relating to SQL execution. A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add KV stats to TraceAnalyzer cathymw/cockroach
2 participants
@asubiotto @cathymw